netdev - Re: [PATCH nf 2/3] netfilter: ipvs: allow rescheduling after RST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1603051500180.1715@ja.home.ssi.bg>
Date:	Sat, 5 Mar 2016 15:01:13 +0200 (EET)
From:	Julian Anastasov <ja@....bg>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
cc:	Simon Horman <horms@...ge.net.au>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org,
	Wensong Zhang <wensong@...ux-vs.org>
Subject: Re: [PATCH nf 2/3] netfilter: ipvs: allow rescheduling after RST


	Hello,

On Thu, 18 Feb 2016, Sergei Shtylyov wrote:

> On 2/18/2016 3:41 AM, Simon Horman wrote:
> 
> > From: Julian Anastasov <ja@....bg>
> >
> > "RFC 5961, 4.2. Mitigation" describes a mechanism to request
> > client to confirm with RST the restart of TCP connection
> > before resending its SYN. As result, IPVS can see SYNs for
> > existing connection in CLOSE state. Add check to allow
> > rescheduling in this state.
> >
> > Signed-off-by: Julian Anastasov <ja@....bg>
> > Signed-off-by: Simon Horman <horms@...ge.net.au>
> > ---
> >   net/netfilter/ipvs/ip_vs_core.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/net/netfilter/ipvs/ip_vs_core.c
> > b/net/netfilter/ipvs/ip_vs_core.c
> > index 4da560005b0e..0c1d3fef9a7c 100644
> > --- a/net/netfilter/ipvs/ip_vs_core.c
> > +++ b/net/netfilter/ipvs/ip_vs_core.c
> > @@ -1089,6 +1089,7 @@ static inline bool is_new_conn_expected(const struct
> > ip_vs_conn *cp,
> >    switch (cp->protocol) {
> >    case IPPROTO_TCP:
> >   		return (cp->state == IP_VS_TCP_S_TIME_WAIT) ||
> > +			cp->state == IP_VS_TCP_S_CLOSE ||
> 
>    I would have been consistent and enclosed this expression into parens as
> well. BTW, the indentation is not correct anyway.

	Thanks! I'll send new version...

> 
> >      ((conn_reuse_mode & 2) &&
> >       (cp->state == IP_VS_TCP_S_FIN_WAIT) &&
> >       (cp->flags & IP_VS_CONN_F_NOOUTPUT));
> 
> MBR, Sergei

Regards

--
Julian Anastasov <ja@....bg>