netdev - Re: [PATCH net] sctp: use gfp insteaad of GFP_NOWAIT in idr_alloc_cyclic when sctp_assoc_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_faS8mNtUNiVT6d-kLRnngQ=4+z6meuO0XM+RJG50iaNw@mail.gmail.com>
Date:	Sun, 6 Mar 2016 13:52:30 +0800
From:	Xin Long <lucien.xin@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
	Vlad Yasevich <vyasevich@...il.com>, daniel@...earbox.net,
	davem <davem@...emloft.net>
Subject: Re: [PATCH net] sctp: use gfp insteaad of GFP_NOWAIT in
 idr_alloc_cyclic when sctp_assoc_set_id

On Sun, Mar 6, 2016 at 12:42 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On sam., 2016-03-05 at 23:59 +0800, Xin Long wrote:
>
> Are you sure idr_alloc(... GFP_KERNEL) makes sense inside spin_lock_bh()
> section ?
>
> idr_alloc() has :
>
> might_sleep_if(gfpflags_allow_blocking(gfp_mask));
>
> A debug kernel (CONFIG_DEBUG_ATOMIC_SLEEP=y) should probably complain at
> this point ?
>
OK, I got you, does it make sense to you if I just change GFP_NOWAIT
to GFP_ATOMIC
when sctp_assoc_set_id call idr_alloc_cyclic()?  which also can avoid
this call trace in my
test.

>
>