netdev - Re: [PATCH V2 1/1] be2net: Don't leak iomapped memory on removal.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160307.153850.1268417717786820672.davem@davemloft.net>
Date:	Mon, 07 Mar 2016 15:38:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dougmill@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, sathya.perla@...adcom.com,
	ajit.khaparde@...adcom.com, padmanabh.ratnakar@...adcom.com,
	sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com
Subject: Re: [PATCH V2 1/1] be2net: Don't leak iomapped memory on removal.

From: Douglas Miller <dougmill@...ux.vnet.ibm.com>
Date: Fri,  4 Mar 2016 15:36:56 -0600

> The adapter->pcicfg resource is either mapped via pci_iomap() or
> derived from adapter->db. During be_remove() this resource was ignored
> and so could remain mapped after remove.
> 
> Add a flag to track whether adapter->pcicfg was mapped or not, then
> use that flag in be_unmap_pci_bars() to unmap if required.
> 
> Fixes: 25848c901 ("use PCI MMIO read instead of config read for errors")
> 
> Signed-off-by: Douglas Miller <dougmill@...ux.vnet.ibm.com>

Applied.