netdev - Re: [PATCH net 2/2] jme: Fix device PM wakeup API usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160307.154002.1727124227884131032.davem@davemloft.net>
Date:	Mon, 07 Mar 2016 15:40:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	cooldavid@...ldavid.org
Cc:	netdev@...r.kernel.org, diego.viola@...il.com
Subject: Re: [PATCH net 2/2] jme: Fix device PM wakeup API usage

From: cooldavid@...ldavid.org
Date: Sat,  5 Mar 2016 08:11:56 +0800

> From: Guo-Fu Tseng <cooldavid@...ldavid.org>
> 
> According to Documentation/power/devices.txt
> 
> The driver should not use device_set_wakeup_enable() which is the policy
> for user to decide.
> 
> Using device_init_wakeup() to initialize dev->power.should_wakeup and
> dev->power.can_wakeup on driver initialization.
> 
> And use device_may_wakeup() on suspend to decide if WoL function should
> be enabled on NIC.
> 
> Reported-by: Diego Viola <diego.viola@...il.com>
> Signed-off-by: Guo-Fu Tseng <cooldavid@...ldavid.org>

Applied.