netdev - Re: [PATCH net-next] ip_tunnel, bpf: ip_tunnel_info_opts_{get,set} depends on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160308225915.GA37181@ast-mbp.thefacebook.com>
Date:	Tue, 8 Mar 2016 14:59:16 -0800
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Daniel Borkmann <daniel@...earbox.net>
Cc:	davem@...emloft.net, tgraf@...g.ch, fengguang.wu@...el.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ip_tunnel, bpf: ip_tunnel_info_opts_{get,set}
 depends on CONFIG_INET

On Tue, Mar 08, 2016 at 11:36:03PM +0100, Daniel Borkmann wrote:
> Helpers like ip_tunnel_info_opts_{get,set}() are only available if
> CONFIG_INET is set, thus add an empty definition into the header for
> the !CONFIG_INET case, where already other empty inline helpers are
> defined.
> 
> This avoids ifdef kludge inside filter.c, but also vxlan and geneve
> themself where this facility can only be used with, depend on INET
> being set. For the !INET case TUNNEL_OPTIONS_PRESENT would never be
> set in flags.
> 
> Fixes: 14ca0751c96f ("bpf: support for access to tunnel options")
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Acked-by: Alexei Starovoitov <ast@...nel.org>