netdev - Re: [PATCH net-next] ip_tunnel, bpf: ip_tunnel_info_opts_{get,set} depends on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160308.232107.2293307827554042545.davem@davemloft.net>
Date:	Tue, 08 Mar 2016 23:21:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	alexei.starovoitov@...il.com, tgraf@...g.ch,
	fengguang.wu@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ip_tunnel, bpf: ip_tunnel_info_opts_{get,set}
 depends on CONFIG_INET

From: Daniel Borkmann <daniel@...earbox.net>
Date: Tue,  8 Mar 2016 23:36:03 +0100

> Helpers like ip_tunnel_info_opts_{get,set}() are only available if
> CONFIG_INET is set, thus add an empty definition into the header for
> the !CONFIG_INET case, where already other empty inline helpers are
> defined.
> 
> This avoids ifdef kludge inside filter.c, but also vxlan and geneve
> themself where this facility can only be used with, depend on INET
> being set. For the !INET case TUNNEL_OPTIONS_PRESENT would never be
> set in flags.
> 
> Fixes: 14ca0751c96f ("bpf: support for access to tunnel options")
> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

Applied, thanks Daniel.