netdev - Re: [PATCH net 4/4] net: hns: remove useless head=ring->next_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 Mar 2016 16:02:04 +0800
From:	Lisheng011 <lisheng011@...wei.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	<davem@...emloft.net>
CC:	<yisen.zhuang@...wei.com>, <yankejian@...wei.com>,
	<xieqianqian@...wei.com>, <huangdaode@...ilicon.com>,
	<salil.mehta@...wei.com>, <netdev@...r.kernel.org>,
	<haifeng.wei@...wei.com>, <charles.chenxin@...wei.com>,
	<linuxarm@...wei.com>
Subject: Re: [PATCH net 4/4] net: hns: remove useless head=ring->next_to_clean



在 2016/3/8 15:18, Andy Shevchenko 写道:
> On Tue, 2016-03-08 at 11:52 +0800, Lisheng wrote:
>> From: Qianqian Xie <xieqianqian@...wei.com>
>>
>> The variable head in hns_nic_tx_fini_pro has read a value,
>> but the value is not used. The patch will solve it.
>>
>> Signed-off-by: Qianqian Xie <xieqianqian@...wei.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> index 3f77ff7..7b4ec2f 100644
>> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> @@ -901,10 +901,8 @@ static int hns_nic_tx_poll_one(struct
>> hns_nic_ring_data *ring_data,
>>   static void hns_nic_tx_fini_pro(struct hns_nic_ring_data *ring_data)
>>   {
>>   	struct hnae_ring *ring = ring_data->ring;
>> -	int head = ring->next_to_clean;
>>   
> This empty line is a leftover, I prefer to just cut assignment.

Yeah,  the empty line does not be needed. I'll remove it. thx.



>> -	/* for hardware bug fixed */
> This is not good. Explanation is needed why you removed this comment.

This bug-fixed comment is for the function pointer 
ring_data->fini_process,that is called in function hns_nic_common_poll.
The comment should not be here, so remove it.


>> -	head = readl_relaxed(ring->io_base + RCB_REG_HEAD);
>> +	int head = readl_relaxed(ring->io_base + RCB_REG_HEAD);
>>   
>>   	if (head != ring->next_to_clean) {
>>   		ring_data->ring->q->handle->dev->ops-
>>> toggle_ring_irq(