netdev - Re: [PATCH net 4/4] net: hns: remove useless head=ring->next_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1457424754.1347.10.camel@linux.intel.com>
Date:	Tue, 08 Mar 2016 10:12:34 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Lisheng011 <lisheng011@...wei.com>, davem@...emloft.net
Cc:	yisen.zhuang@...wei.com, yankejian@...wei.com,
	xieqianqian@...wei.com, huangdaode@...ilicon.com,
	salil.mehta@...wei.com, netdev@...r.kernel.org,
	haifeng.wei@...wei.com, charles.chenxin@...wei.com,
	linuxarm@...wei.com
Subject: Re: [PATCH net 4/4] net: hns: remove useless
 head=ring->next_to_clean

On Tue, 2016-03-08 at 16:02 +0800, Lisheng011 wrote:
> 
> 在 2016/3/8 15:18, Andy Shevchenko 写道:
> > 
> > On Tue, 2016-03-08 at 11:52 +0800, Lisheng wrote:
> > > 
> > > From: Qianqian Xie <xieqianqian@...wei.com>
> > > 
> > > The variable head in hns_nic_tx_fini_pro has read a value,
> > > but the value is not used. The patch will solve it.


> -	/* for hardware bug fixed */
> > This is not good. Explanation is needed why you removed this
> > comment.

> This bug-fixed comment is for the function pointer 
> ring_data->fini_process,that is called in function
> hns_nic_common_poll.


> The comment should not be here, so remove it.

Please, add above paragraph to the commit message.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy