netdev - Re: [PATCH] inet: set `error' value not under lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160309.153715.770009288781656553.davem@davemloft.net>
Date:	Wed, 09 Mar 2016 15:37:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	wjeong@...racuda.com, weongyo.linux@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] inet: set `error' value not under lock_sock().

From: Weongyo Jeong <weongyo.linux@...il.com>
Date: Wed, 9 Mar 2016 10:22:21 -0800

> A trivial patch to set `error' variable while not holding
> lock_sock().
> 
> Signed-off-by: Weongyo Jeong <weongyo.linux@...il.com>

Deferring the assignment means gcc doesn't have to potentially put it
on the stack across the lock_sock() call.

You're making the code worse not better, the assignment into a local
variable is not an expensive operation.

I'm not applying this change, sorry.