netdev - Re: [PATCH] inet: set `error' value not under lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56E0A7AC.70806@barracuda.com>
Date:	Wed, 9 Mar 2016 14:46:04 -0800
From:	Weongyo Jeong <wjeong@...racuda.com>
To:	David Miller <davem@...emloft.net>,
	"weongyo.linux@...il.com" <weongyo.linux@...il.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] inet: set `error' value not under lock_sock().

On 03/09/2016 12:37 PM, David Miller wrote:
> From: Weongyo Jeong <weongyo.linux@...il.com>
> Date: Wed, 9 Mar 2016 10:22:21 -0800
>
>> A trivial patch to set `error' variable while not holding
>> lock_sock().
>>
>> Signed-off-by: Weongyo Jeong <weongyo.linux@...il.com>
>
> Deferring the assignment means gcc doesn't have to potentially put it
> on the stack across the lock_sock() call.
>
> You're making the code worse not better, the assignment into a local
> variable is not an expensive operation.
>
> I'm not applying this change, sorry.

No problem.  Thank you for review and opinion.

Regards,
Weongyo Jeong

===========================================================

Considering Office 365?  Barracuda security and storage solutions can help. Learn more about Barracuda solutions for Office 365 at http://barracuda.com/office365.

DISCLAIMER:
This e-mail and any attachments to it contain confidential and proprietary material of Barracuda, its affiliates or agents, and is solely for the use of the intended recipient. Any review, use, disclosure, distribution or copying of this transmittal is prohibited except by or on behalf of the intended recipient. If you have received this transmittal in error, please notify the sender and destroy this e-mail and any attachments and all copies, whether electronic or printed.