netdev - Re: [PATCH net-next 1/5] dsa: Rename mv88e6123_61

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87io0qua3u.fsf@ketchup.mtl.sfl>
Date:	Sun, 13 Mar 2016 03:10:13 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next 1/5] dsa: Rename mv88e6123_61_65 to mv88e6123 to be consistent

Andrew Lunn <andrew@...n.ch> writes:

> All the drivers support multiple chips, but mv88e6123_61_65 is the
> only one that reflects this in its naming. Change it to be consistent
> with the other drivers.
>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

When mv88e6xxx will become a driver by its own supporting different
devices, it'll be good to rename it to a reference driver as well, say
mv88e6352.

[...]

> diff --git a/drivers/net/dsa/mv88e6123.c b/drivers/net/dsa/mv88e6123.c
> new file mode 100644
> index 000000000000..69a6f79dcb10
> --- /dev/null
> +++ b/drivers/net/dsa/mv88e6123.c
> @@ -0,0 +1,124 @@

Note that to avoid the big diff above, you can use the -M option of
git-format-patch to detect file renames.

Thanks,
Vivien