netdev - Re: [PATCH net-next 1/5] dsa: Rename mv88e6123_61

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160313155131.GE9674@lunn.ch>
Date:	Sun, 13 Mar 2016 16:51:31 +0100
From:	Andrew Lunn <andrew@...n.ch>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 1/5] dsa: Rename mv88e6123_61_65 to mv88e6123 to
 be consistent

On Sun, Mar 13, 2016 at 03:10:13AM -0400, Vivien Didelot wrote:
> Andrew Lunn <andrew@...n.ch> writes:
> 
> > All the drivers support multiple chips, but mv88e6123_61_65 is the
> > only one that reflects this in its naming. Change it to be consistent
> > with the other drivers.
> >
> > Signed-off-by: Andrew Lunn <andrew@...n.ch>
> 
> Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
> 
> When mv88e6xxx will become a driver by its own supporting different
> devices, it'll be good to rename it to a reference driver as well, say
> mv88e6352.

In device tree land, the convention is to use the lowest version
number supported. So it will probably be called mv88e6085.c.

> 
> > diff --git a/drivers/net/dsa/mv88e6123.c b/drivers/net/dsa/mv88e6123.c
> > new file mode 100644
> > index 000000000000..69a6f79dcb10
> > --- /dev/null
> > +++ b/drivers/net/dsa/mv88e6123.c
> > @@ -0,0 +1,124 @@
> 
> Note that to avoid the big diff above, you can use the -M option of
> git-format-patch to detect file renames.

Yes, i always forget that. I wounder why it is not turned on by
default? Maybe older versions of patch do not understand it?

	 Andrew