netdev - Re: [PATCH net] ipv4: initialize flowi4_flags before calling fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpURYG=Z-2CO3W57LpKysjx8-173=Kcwbe_=RQbyERCy4A@mail.gmail.com>
Date:	Tue, 22 Mar 2016 14:10:49 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	David Ahern <dsa@...ulusnetworks.com>
Cc:	Lance Richardson <lrichard@...hat.com>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net] ipv4: initialize flowi4_flags before calling fib_lookup()

On Tue, Mar 22, 2016 at 2:02 PM, David Ahern <dsa@...ulusnetworks.com> wrote:
> On 3/22/16 2:45 PM, Cong Wang wrote:
>>
>> @@ -1426,7 +1426,7 @@ int fib_table_lookup(struct fib_table *tb, const
>> struct flowi4 *flp,
>>                              nh->nh_flags & RTNH_F_LINKDOWN &&
>>                              !(fib_flags & FIB_LOOKUP_IGNORE_LINKSTATE))
>>                                  continue;
>> -                       if (!(flp->flowi4_flags & FLOWI_FLAG_VRFSRC)) {
>> +                       if (!(flp->flowi4_flags & FLOWI_FLAG_SKIP_NH_OIF))
>> {
>>                                  if (flp->flowi4_oif &&
>>                                      flp->flowi4_oif != nh->nh_oif)
>>                                          continue;
>>
>> For me, it looks the bug was introduce by commit
>> 35ebf65e851c6d9731abc6362b1.
>>
>
> Arguably yes since it added the function without initializing flags.
>
> The commit I referenced (and even the VRF predecessor both of which
> originated in the v4.3) is the one introducing use of flow flags to the
> lookup. From a stable perspective going back to v4.3 is what matters.
>

Yeah, then it is commit 613d09b30f8b589d5a9b497. It doesn't matter
for backport, but matters for accuracy. ;)