lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <56F1BA16.9070601@cogentembedded.com> Date: Wed, 23 Mar 2016 00:33:10 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: David Miller <davem@...hat.com> Cc: netdev@...r.kernel.org, nicolas.ferre@...el.com Subject: Re: [PATCH] macb: fix PHY reset On 03/22/2016 11:07 PM, David Miller wrote: >> On 03/22/2016 10:27 PM, Sergei Shtylyov wrote: >> >>> The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and >>> 1, as >>> a result the PHY isn't really put back into reset state in >>> macb_remove(). >>> Moreover, the driver assumes that something else has set the GPIO >>> direction >>> to output, so if it has not, the PHY wouldn't be taken out of reset in >> >> s/wouldn't/may not/, sorry. Do I need to resend? > > No need, I fixed it up by hand. > > Applied, thanks. Oops, forgot another tag: Fixes: 270c499f0993 ("net/macb: Update device tree binding for resetting PHY using GPIO") Too late probably... :-( MBR, Sergei
Powered by blists - more mailing lists