netdev - Re: [PATCH net 01/10] net: hns: bug fix about ping6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F095D2.70604@huawei.com>
Date:	Tue, 22 Mar 2016 08:46:10 +0800
From:	Yisen Zhuang <Yisen.zhuang@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<yankejian@...wei.com>, <huangdaode@...ilicon.com>,
	<salil.mehta@...wei.com>, <lisheng011@...wei.com>,
	<lipeng321@...wei.com>, <liguozhu@...wei.com>, <arnd@...db.de>,
	<xieqianqian@...wei.com>, <andrew@...n.ch>, <ivecera@...hat.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linuxarm@...wei.com>
Subject: Re: [PATCH net 01/10] net: hns: bug fix about ping6



在 2016/3/21 23:39, David Miller 写道:
> From: Yisen Zhuang <Yisen.Zhuang@...wei.com>
> Date: Mon, 21 Mar 2016 19:06:32 +0800
> 
>> From: Kejian Yan <yankejian@...wei.com>
>>
>> The current upstreaming code fails to ping other IPv6 net device, because
>> the enet receives the multicast packets with the src mac addr whick is the
>                                                                 ^^^^^
> 
> "which"

Will fix it in next submit.

Thanks

> 
>> @@ -670,6 +671,14 @@ out_bnum_err:
>>  		return -EFAULT;
>>  	}
>>  
>> +	/* filter out multicast pkt with the same src mac as this port */
>> +	eh = (struct ethhdr *)skb->data;
> 
> Please use the "eth_hdr()" helper.

Will fix it in next submit.

Thanks,

Yisen

> 
> .
>