netdev - Re: [PATCH net 03/10] net: hns: add uc match for debug ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F099D0.3070102@huawei.com>
Date:	Tue, 22 Mar 2016 09:03:12 +0800
From:	Yisen Zhuang <Yisen.zhuang@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<yankejian@...wei.com>, <huangdaode@...ilicon.com>,
	<salil.mehta@...wei.com>, <lisheng011@...wei.com>,
	<lipeng321@...wei.com>, <liguozhu@...wei.com>, <arnd@...db.de>,
	<xieqianqian@...wei.com>, <andrew@...n.ch>, <ivecera@...hat.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linuxarm@...wei.com>
Subject: Re: [PATCH net 03/10] net: hns: add uc match for debug ports



在 2016/3/21 23:40, David Miller 写道:
> From: Yisen Zhuang <Yisen.Zhuang@...wei.com>
> Date: Mon, 21 Mar 2016 19:06:34 +0800
> 
>> +	(void)hns_mac_set_promisc(mac_cb, (u8)!!en);
> 
> This cast to void is unnecssary.

I think hns_mac_set_promisc don't need to return a value， so i will fix it in next submit.

Thanks

> 
>> +static void hns_gmac_set_uc_match(void *mac_drv, u16 en)
>> +{
>> +	struct mac_driver *drv = (struct mac_driver *)mac_drv;
> 
> Casts from void pointers are unnecessary.

Will fix it in next submit.

Thanks

> 
>> +{
>> +	struct mac_driver *drv = (struct mac_driver *)mac_drv;
> 
> Likewise.

Will fix it in next submit.

Thanks,

Yisen

> 
> .
>