netdev - Re: net/sctp: stack-out-of-bounds in sctp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1458753290.10868.38.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Wed, 23 Mar 2016 10:14:50 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Baozeng <sploving1@...il.com>
Cc:	pablo@...filter.org, kaber@...sh.net, kadlec@...ckhole.kfki.hu,
	coreteam@...filter.org, netfilter-devel@...r.kernel.org,
	Vladislav Yasevich <vyasevich@...il.com>,
	nhorman@...driver.com, davem@...emloft.net,
	linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: net/sctp: stack-out-of-bounds in sctp_getsockopt

On Thu, 2016-03-24 at 00:42 +0800, Baozeng wrote:

> Thanks for your quick patch. I tested it but it still reproduce the
> bug. We should limit the length of the name,
> not the prefix. The following patch fixs it.
> 
> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
> index 67b2e27..4837425 100644
> --- a/net/bridge/netfilter/ebtables.c
> +++ b/net/bridge/netfilter/ebtables.c
> @@ -346,7 +346,7 @@ find_inlist_lock(struct list_head *head, const
> char *name, const char *prefix,
>  {
>         return try_then_request_module(
>                         find_inlist_lock_noload(head, name, error, mutex),
> -                       "%s%s", prefix, name);
> +                       "%s%.*s", prefix, EBT_TABLE_MAXNAMELEN, name);
> }
> 

Right you are, please send a formal patch ?

Thanks !