lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <56F2CF7A.9070104@cloudius-systems.com>
Date:	Wed, 23 Mar 2016 19:16:42 +0200
From:	Vlad Zolotarov <vladz@...udius-systems.com>
To:	Bjorn Helgaas <helgaas@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: Fix typos and whitespace.



On 03/23/2016 03:55 PM, Bjorn Helgaas wrote:
> [+cc Vlad]
>
> On Wed, Mar 23, 2016 at 08:45:30AM -0500, Bjorn Helgaas wrote:
>> Fix typos.  Capitalize CPU, NAPI, RCU consistently.  Align structure
>> indentation.  No functional change intended; only comment and whitespace
>> changes.
>>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
>> ---
>>   include/linux/netdevice.h |  215 ++++++++++++++++++++++-----------------------
>> @@ -920,7 +920,7 @@ struct tc_to_netdev {
>>    *
>>    *      Enable or disable the VF ability to query its RSS Redirection Table and
>>    *      Hash Key. This is needed since on some devices VF share this information
>> - *      with PF and querying it may adduce a theoretical security risk.
>> + *      with PF and querying it may introduce a theoretical security risk.
>>    * int (*ndo_set_vf_rss_query_en)(struct net_device *dev, int vf, bool setting)
> Most of these are obvious typo fixes, but I want to point out this one
> in particular because "adduce" is a real word.  It's possible that's
> what Vlad intended in 01a3d796813d ("if_link: Add an additional
> parameter to ifla_vf_info for RSS querying"), though it doesn't quite
> seem to fit.  Vlad, if you did intend "adduce", my apologies in
> advance.

Of course it was a typo :D
Thanks for fixing it, Bjorn.

>
> Bjorn

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ