netdev - Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160323.134024.1861895182788231473.davem@davemloft.net>
Date:	Wed, 23 Mar 2016 13:40:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sf84@...oste.net
Cc:	u.kleine-koenig@...gutronix.de, daniel@...que.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	slash.tmp@...e.fr, f.fainelli@...il.com, mans@...sr.com,
	festevam@...il.com, martin.blumenstingl@...il.com,
	linus.walleij@...aro.org
Subject: Re: [PATCH] net: phy: at803x: Request 'reset' GPIO only for AT8030
 PHY

From: Sebastian Frias <sf84@...oste.net>
Date: Wed, 23 Mar 2016 11:49:09 +0100

> This removes the dependency on GPIOLIB for non faulty PHYs.
> 
> Indeed, without this patch, if GPIOLIB is not selected
> devm_gpiod_get_optional() will return -ENOSYS and the driver probe
> call will fail, regardless of the actual PHY hardware.
> 
> Out of the 3 PHYs supported by this driver (AT8030, AT8031, AT8035),
> only AT8030 presents the issues that commit 13a56b449325 ("net: phy:
> at803x: Add support for hardware reset") attempts to work-around by
> using a 'reset' GPIO line.
> 
> Hence, only AT8030 should depend on GPIOLIB operating properly.
> 
> Fixes: 13a56b449325 ("net: phy: at803x: Add support for hardware reset")
> 
> Signed-off-by: Sebastian Frias <sf84@...oste.net>

Applied.