netdev - Re: [PATCH net-next v3.16]r8169: Add delay on set_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1459012758.6473.73.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Sat, 26 Mar 2016 10:19:18 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Corcodel Marian <asd@...ian1000.go.ro>
Cc:	netdev@...r.kernel.org, Francois Romieu <romieu@...zoreil.com>
Subject: Re: [PATCH net-next v3.16]r8169: Add delay on set_rx_mode

On Sat, 2016-03-26 at 13:21 +0200, Corcodel Marian wrote:
>  Set one line  space extra delay on set_rx_mode for starting
>    on full duplex and full speed.
> 
> Signed-off-by: Corcodel Marian <asd@...ian1000.go.ro>
> ---
>  drivers/net/ethernet/realtek/r8169.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 0ae8969..457b12a 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -4646,6 +4646,7 @@ static void rtl_set_rx_mode(struct net_device *dev)
>  		mc_filter[1] = mc_filter[0] = 0xffffffff;
>  
>  	RTL_W32(MAR0 + 4, mc_filter[1]);
> +
>  	RTL_W32(MAR0 + 0, mc_filter[0]);
>  
>  	RTL_W32(RxConfig, tmp);

Seriously ?