netdev - [RFC] net: mvneta: 64bit platform support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160330213700.41876e09@xhacker>
Date:	Wed, 30 Mar 2016 21:37:00 +0800
From:	Jisheng Zhang <jszhang@...vell.com>
To:	<thomas.petazzoni@...e-electrons.com>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<gregory.clement@...e-electrons.com>, <mw@...ihalf.com>
Subject: [RFC] net: mvneta: 64bit platform support

Hi all,

Obviously, current mvneta driver can't work on 64bit platforms. For one thing
the BM feature should be explicitly disabled, I just sent out one patch for
this purpose. 

What's more, the buf_cookie in mvneta_rx_desc need to be carefully considered.
The driver use the buf_cookie(u32 type) to store the buffer virtual address,
obviously it can't store the virtual address on 64bit platforms. I have two
solutions:

solution A: let one reserved type in current mvneta_rx_desc, e.g reserved5
to store the high 32bit virt address, and hack code as the following:
#ifdef CONFIG_64BIT
rx_desc->reserved5 = high32(data);
#endif

solution B: add one member void **buf_virt_ptrs in mvneta_rx_queue, and point
all buf_cookie usage to the according buf_virt_ptrs[i]

Is there any elegant solutions?

Thanks,
Jisheng