netdev - RE: [net PATCH 2/2] ipv4/GRO: Make GRO conform to RFC 6864

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Apr 2016 15:13:42 -0600
From:	"Subash Abhinov Kasiviswanathan" <subashab@...eaurora.org>
To:	"'Alexander Duyck'" <alexander.duyck@...il.com>,
	"'David Miller'" <davem@...emloft.net>
Cc:	"'Eric Dumazet'" <eric.dumazet@...il.com>,
	"'Alex Duyck'" <aduyck@...antis.com>,
	"'Herbert Xu'" <herbert@...dor.apana.org.au>,
	"'Tom Herbert'" <tom@...bertland.com>,
	"'Jesse Gross'" <jesse@...nel.org>,
	"'Eric Dumazet'" <edumazet@...gle.com>,
	"'Netdev'" <netdev@...r.kernel.org>
Subject: RE: [net PATCH 2/2] ipv4/GRO: Make GRO conform to RFC 6864

|  For transmit we can leave the IP ID code as is.  For receive we should not be
|  snooping into the IP ID for any frames that have the DF bit set as devices
|  that have adopted RFC 6864 on their transmit path will end up causing issues.

Currently, GRO does not coalesce TCP packets originating from nodes which do IPv6 to IPv4 translation.
These packets have DF set to 1 and IP ID set 0 according to https://tools.ietf.org/html/rfc6145#page-17 

With this patch, we should be able to see coalescing happen for those cases as well.