netdev - RE: [PATCH net-next 1/3] net: bcmgenet: cleanup for bcmgenet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D54DC5E88@AcuExch.aculab.com>
Date:	Wed, 6 Apr 2016 08:57:28 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Petri Gynther' <pgynther@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"jaedon.shin@...il.com" <jaedon.shin@...il.com>
Subject: RE: [PATCH net-next 1/3] net: bcmgenet: cleanup for bcmgenet_xmit()

From: Petri Gynther
> Sent: 05 April 2016 01:10
...
> 2. Readability: Add parentheses around nr_frags + 1.
...
> -	if (ring->free_bds <= nr_frags + 1) {
...
> +	if (ring->free_bds <= (nr_frags + 1)) {

The extra () are not needed and do not improve readability.

	David