netdev - Re: [net-next:master 194/196] include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160407.170937.292677537698351913.davem@davemloft.net>
Date:	Thu, 07 Apr 2016 17:09:37 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fengguang.wu@...el.com
Cc:	hannes@...essinduktion.org, kbuild-all@...org,
	netdev@...r.kernel.org
Subject: Re: [net-next:master 194/196] include/net/sock.h:1367:9: error:
 implicit declaration of function 'lockdep_is_held'

From: kbuild test robot <fengguang.wu@...el.com>
Date: Fri, 8 Apr 2016 05:00:42 +0800

>    include/net/sock.h: In function 'lockdep_sock_is_held':
>>> include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is_held' [-Werror=implicit-function-declaration]
>      return lockdep_is_held(&sk->sk_lock) ||
...
>   1361	} while (0)
>   1362	
>   1363	static bool lockdep_sock_is_held(const struct sock *csk)
>   1364	{
>   1365		struct sock *sk = (struct sock *)csk;
>   1366	
>> 1367		return lockdep_is_held(&sk->sk_lock) ||
>   1368		       lockdep_is_held(&sk->sk_lock.slock);
>   1369	}

Hmmm, Hannes to we need to make this a macro just like lockdep_is_held() is?