netdev - Re: [net-next:master 194/196] include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1460067127.988018.572315241.7F1FE712@webmail.messagingengine.com>
Date:	Fri, 08 Apr 2016 00:12:07 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	David Miller <davem@...emloft.net>, fengguang.wu@...el.com
Cc:	kbuild-all@...org, netdev@...r.kernel.org
Subject: Re: [net-next:master 194/196] include/net/sock.h:1367:9: error: implicit
 declaration of function 'lockdep_is_held'



On Thu, Apr 7, 2016, at 23:09, David Miller wrote:
> From: kbuild test robot <fengguang.wu@...el.com>
> Date: Fri, 8 Apr 2016 05:00:42 +0800
> 
> >    include/net/sock.h: In function 'lockdep_sock_is_held':
> >>> include/net/sock.h:1367:9: error: implicit declaration of function 'lockdep_is_held' [-Werror=implicit-function-declaration]
> >      return lockdep_is_held(&sk->sk_lock) ||
> ...
> >   1361	} while (0)
> >   1362	
> >   1363	static bool lockdep_sock_is_held(const struct sock *csk)
> >   1364	{
> >   1365		struct sock *sk = (struct sock *)csk;
> >   1366	
> >> 1367		return lockdep_is_held(&sk->sk_lock) ||
> >   1368		       lockdep_is_held(&sk->sk_lock.slock);
> >   1369	}
> 
> Hmmm, Hannes to we need to make this a macro just like lockdep_is_held()
> is?

I think my newest patch should fix it. I simply forgot the inline
keyword. inline functions get invisible if not used by the compiler.

Sorry,
Hannes