netdev - Re: [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160414154700.GE12583@htj.duckdns.org>
Date:	Thu, 14 Apr 2016 11:47:00 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Manish Chopra <manish.chopra@...gic.com>
Cc:	Amitoj Kaur Chawla <amitoj1606@...il.com>,
	Sudarsana Kalluru <Sudarsana.Kalluru@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dept-Eng Linux Driver <Linux-Driver@...gic.com>,
	Harish Patil <harish.patil@...gic.com>,
	Dept-GE Linux NIC Dev <Dept-GELinuxNICDev@...gic.com>
Subject: Re: [PATCH] qlge: Replace create_singlethread_workqueue with
 alloc_ordered_workqueue

Hello, Manish.

On Thu, Apr 14, 2016 at 07:25:15AM +0000, Manish Chopra wrote:
> Just want to confirm that __WQ_LEGACY flag is not necessary here as this is removed
> with this change ? 

Yeah, that should be fine.  That only affects locking dependency
tracking which can fire spuriously due to workqueues created with the
old interface having WQ_MEM_RECLAIM unconditionally.  In this case, we
actually want WQ_MEM_RECLAIM and thus we want the dependency tracking
too.

Thanks.

-- 
tejun