netdev - RE: [PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLUPR11MB011498CD02CC919F023545E793970@BLUPR11MB0114.namprd11.prod.outlook.com>
Date:	Thu, 14 Apr 2016 07:25:15 +0000
From:	Manish Chopra <manish.chopra@...gic.com>
To:	Tejun Heo <tj@...nel.org>,
	Amitoj Kaur Chawla <amitoj1606@...il.com>
CC:	Sudarsana Kalluru <Sudarsana.Kalluru@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dept-Eng Linux Driver <Linux-Driver@...gic.com>,
	Harish Patil <harish.patil@...gic.com>,
	Dept-GE Linux NIC Dev <Dept-GELinuxNICDev@...gic.com>
Subject: RE: [PATCH] qlge: Replace create_singlethread_workqueue with
	alloc_ordered_workqueue

> -----Original Message-----
> From: dept_hsg_linux_nic_dev-bounces@...listserver.qlogic.com
> [mailto:dept_hsg_linux_nic_dev-bounces@...listserver.qlogic.com] On Behalf
> Of Tejun Heo
> Sent: Wednesday, April 13, 2016 11:14 PM
> To: Amitoj Kaur Chawla <amitoj1606@...il.com>
> Cc: Sudarsana Kalluru <Sudarsana.Kalluru@...gic.com>; netdev
> <netdev@...r.kernel.org>; linux-kernel <linux-kernel@...r.kernel.org>; Dept-
> Eng Linux Driver <Linux-Driver@...gic.com>; Harish Patil
> <harish.patil@...gic.com>; Dept-GE Linux NIC Dev <Dept-
> GELinuxNICDev@...gic.com>
> Subject: Re: [PATCH] qlge: Replace create_singlethread_workqueue with
> alloc_ordered_workqueue
> 
> On Sat, Apr 09, 2016 at 05:27:45PM +0530, Amitoj Kaur Chawla wrote:
> > Replace deprecated create_singlethread_workqueue with
> > alloc_ordered_workqueue.
> >
> > Work items include getting tx/rx frame sizes, resetting MPI processor,
> > setting asic recovery bit so ordering seems necessary as only one work
> > item should be in queue/executing at any given time, hence the use of
> > alloc_ordered_workqueue.
> >
> > WQ_MEM_RECLAIM flag has been set since ethernet devices seem to sit in
> > memory reclaim path, so to guarantee forward progress regardless of
> > memory pressure.
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> > Acked-by: Tejun Heo <tj@...nel.org>
> 
> Ping?
> 

Hi,
Just want to confirm that __WQ_LEGACY flag is not necessary here as this is removed
with this change ? 

Thanks