netdev - Re: [PATCH net-next 0/2] fix two more udp pull header issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF=yD-JQeHCNQAeoDPB8p5WkMDKt+5+WB3zh73PPYxTSaab2_A@mail.gmail.com>
Date:	Wed, 13 Apr 2016 22:57:33 -0400
From:	Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Network Development <netdev@...r.kernel.org>,
	Tom Herbert <tom@...bertland.com>,
	Sam Kumar <samanthakumar@...gle.com>,
	Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next 0/2] fix two more udp pull header issues

On Wed, Apr 13, 2016 at 10:25 PM, David Miller <davem@...emloft.net> wrote:
> From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
> Date: Thu,  7 Apr 2016 18:12:57 -0400
>
>> Follow up patches to the fixes to RxRPC and SunRPC. A scan of the
>> code showed two other interfaces that expect UDP packets to have
>> a udphdr when queued: read packet length with ioctl SIOCINQ and
>> receive payload checksum with socket option IP_CHECKSUM.
>
> As we are seeing, lots of places depend upon the old way of queueing
> up UDP frames. :-/

Yes, I greatly underestimated that. I should have done a much more
thorough scan before submitting. Hopefully we've caught them all now.

> Applied, thanks for mopping all of this up.

Apologies for breaking it in the first place!