netdev - Re: [PATCH] net: ipv6: Do not keep linklocal and loopback addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160413.230002.1718430497071707670.davem@davemloft.net>
Date:	Wed, 13 Apr 2016 23:00:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dsa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: ipv6: Do not keep linklocal and loopback addresses

From: David Ahern <dsa@...ulusnetworks.com>
Date: Fri,  8 Apr 2016 12:01:21 -0700

> f1705ec197e7 added the option to retain user configured addresses on an
> admin down. A comment to one of the later revisions suggested using the
> IFA_F_PERMANENT flag rather than adding a user_managed boolean to the
> ifaddr struct. A side effect of this change is that link local and
> loopback addresses are also retained which is not part of the objective
> of f1705ec197e7. Add check to drop those addresses.
> 
> Fixes: f1705ec197e7 ("net: ipv6: Make address flushing on ifdown optional")
> 
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>

Applied, but two things:

Please do not put an empty line between the Fixes: and other tags.
All tags are equal and should be placed together as an unsegmented
unit.

Second, please be really sure this is the final set of semantics
you want.  If we flap again on this after 4.6-final goes out the
door, I will be very unpleased to say the least.

Thanks.