netdev - Re: [net][PATCH v2 2/2] RDS: Fix the atomicity for congestion map update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160416.190142.1728042848852620447.davem@davemloft.net>
Date:	Sat, 16 Apr 2016 19:01:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	santosh.shilimkar@...cle.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net][PATCH v2 2/2] RDS: Fix the atomicity for congestion map
 update

From: Santosh Shilimkar <santosh.shilimkar@...cle.com>
Date: Thu, 14 Apr 2016 10:43:27 -0700

> Two different threads with different rds sockets may be in
> rds_recv_rcvbuf_delta() via receive path. If their ports
> both map to the same word in the congestion map, then
> using non-atomic ops to update it could cause the map to
> be incorrect. Lets use atomics to avoid such an issue.
> 
> Full credit to Wengang <wen.gang.wang@...cle.com> for
> finding the issue, analysing it and also pointing out
> to offending code with spin lock based fix.
> 
> Reviewed-by: Leon Romanovsky <leon@...n.nu>
> Signed-off-by: Wengang Wang <wen.gang.wang@...cle.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>

Applied.