lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 18 Apr 2016 14:34:53 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/5] qede: Add support for ethtool private flags

>> +     flags |= (!!(edev->dev_info.common.num_hwfns > 1)) <<
>> +              QEDE_PRI_FLAG_CMT;

>  Why not just '='?

>> +
>> +     return flags;

>  ... or direct return of the value above?

Probably wanted to lay the basis for future flags.
But you're right in that there's no need for it.
I'll change it in V2.

Thanks,
Yuval

Powered by blists - more mailing lists