netdev - Re: [PATCH 1/3] e1000e: e1000e_cyclecounter_read(): incvalue is 32 bits, not 64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Apr 2016 13:57:14 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] e1000e: e1000e_cyclecounter_read(): incvalue is 32
 bits, not 64

On Tue, 2016-04-19 at 14:34 +0200, Denys Vlasenko wrote:
> "incvalue" variable holds a result of "er32(TIMINCA) &
> E1000_TIMINCA_INCVALUE_MASK"
> and used in "do_div(temp, incvalue)" as a divisor.
> 
> Thus, "u64 incvalue" declaration is probably a mistake.
> Even though it seems to be a harmless one, let's fix it.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> CC: Jesse Brandeburg <jesse.brandeburg@...el.com>
> CC: Shannon Nelson <shannon.nelson@...el.com>
> CC: Carolyn Wyborny <carolyn.wyborny@...el.com>
> CC: Don Skidmore <donald.c.skidmore@...el.com>
> CC: Bruce Allan <bruce.w.allan@...el.com>
> CC: John Ronciak <john.ronciak@...el.com>
> CC: Mitch Williams <mitch.a.williams@...el.com>
> CC: David S. Miller <davem@...emloft.net>
> CC: LKML <linux-kernel@...r.kernel.org>
> CC: netdev@...r.kernel.org
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

First of all, trimmed down the recipient list since almost all of the
reviewers you added have nothing to do with e1000e.

Any chance you can send this to the "correct" list intel-wired-
lan@...ts.osuosl.org?  Kind of amazing that your shotgun blast approach
in emailing out the patch series managed to miss sending it to the one
email list that handles Intel Wired LAN kernel patches.
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)