netdev - Re: [PATCH 1/3] e1000e: e1000e_cyclecounter_read(): incvalue is 32 bits, not 64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5717A389.5070902@redhat.com>
Date:	Wed, 20 Apr 2016 17:43:05 +0200
From:	Denys Vlasenko <dvlasenk@...hat.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] e1000e: e1000e_cyclecounter_read(): incvalue is 32
 bits, not 64

On 04/19/2016 10:57 PM, Jeff Kirsher wrote:
> On Tue, 2016-04-19 at 14:34 +0200, Denys Vlasenko wrote:
>> "incvalue" variable holds a result of "er32(TIMINCA) &
>> E1000_TIMINCA_INCVALUE_MASK"
>> and used in "do_div(temp, incvalue)" as a divisor.
>>
>> Thus, "u64 incvalue" declaration is probably a mistake.
>> Even though it seems to be a harmless one, let's fix it.
>>
>> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
>> CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> CC: Jesse Brandeburg <jesse.brandeburg@...el.com>
>> CC: Shannon Nelson <shannon.nelson@...el.com>
>> CC: Carolyn Wyborny <carolyn.wyborny@...el.com>
>> CC: Don Skidmore <donald.c.skidmore@...el.com>
>> CC: Bruce Allan <bruce.w.allan@...el.com>
>> CC: John Ronciak <john.ronciak@...el.com>
>> CC: Mitch Williams <mitch.a.williams@...el.com>
>> CC: David S. Miller <davem@...emloft.net>
>> CC: LKML <linux-kernel@...r.kernel.org>
>> CC: netdev@...r.kernel.org
>> ---
>>  drivers/net/ethernet/intel/e1000e/netdev.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> First of all, trimmed down the recipient list since almost all of the
> reviewers you added have nothing to do with e1000e.

I took the list here, MAINTAINERS:

INTEL ETHERNET DRIVERS
M:      Jeff Kirsher <jeffrey.t.kirsher@...el.com>
R:      Jesse Brandeburg <jesse.brandeburg@...el.com>
R:      Shannon Nelson <shannon.nelson@...el.com>
R:      Carolyn Wyborny <carolyn.wyborny@...el.com>
R:      Don Skidmore <donald.c.skidmore@...el.com>
R:      Bruce Allan <bruce.w.allan@...el.com>
R:      John Ronciak <john.ronciak@...el.com>
R:      Mitch Williams <mitch.a.williams@...el.com>

No more specific information who's e1000e reviewer.
Sorry.