netdev - RE: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c10cbc575f4d4e15bd27a8018f77baf1@THHSTE15D2BE2.hs20.net>
Date:	Wed, 20 Apr 2016 08:49:34 +0000
From:	Andrew Goodbody <andrew.goodbody@...brionix.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"David Rivshin (Allworx)" <drivshin.allworx@...il.com>,
	"grygorii.strashko@...com" <grygorii.strashko@...com>,
	"mugunthanvnm@...com" <mugunthanvnm@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"tony@...mide.com" <tony@...mide.com>
Subject: RE: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference
 with two slave PHYs

> -----Original Message-----
> From: Andrew Goodbody <andrew.goodbody@...brionix.com>
> Date: Mon, 18 Apr 2016 14:53:25 +0100
> 
> > This is a fix for a NULL pointer dereference from cpsw which is
> > triggered by having two slave PHYs attached to a cpsw network device.
> > The problem is due to only maintaining a single reference to a PHY
> > node in the prive data which gets overwritten by the second PHY probe.
> > So move the PHY node reference to the individual slave data so that there
> is now one per slave.
> >
> > v1 had a problem that data->slaves was used before it had been filled
> > in
> 
> I already applied v1 the other day, so you need to send me a relative patch
> rather than a whole new one.
> 
> Thanks.

Sorry, I had no notification that this had happened. However I thought that the plan was to revert v1 and go with David Rivshin's patch instead. I'll see if I can create a revert in a little while.

Andrew