netdev - Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160419.201550.902520333910307559.davem@davemloft.net>
Date:	Tue, 19 Apr 2016 20:15:50 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	andrew.goodbody@...brionix.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer
 dereference with two slave PHYs

From: Andrew Goodbody <andrew.goodbody@...brionix.com>
Date: Mon, 18 Apr 2016 14:53:25 +0100

> This is a fix for a NULL pointer dereference from cpsw which is triggered
> by having two slave PHYs attached to a cpsw network device. The problem is
> due to only maintaining a single reference to a PHY node in the prive data
> which gets overwritten by the second PHY probe. So move the PHY node
> reference to the individual slave data so that there is now one per slave.
> 
> v1 had a problem that data->slaves was used before it had been filled in

I already applied v1 the other day, so you need to send me a relative
patch rather than a whole new one.

Thanks.