netdev - Re: [PATCH net-next] macvlan: fix failure during registration v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160426.151905.237092605462953849.davem@davemloft.net>
Date:	Tue, 26 Apr 2016 15:19:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fruggeri@...sta.com
Cc:	netdev@...r.kernel.org, ebiederm@...ssion.com, maheshb@...gle.com
Subject: Re: [PATCH net-next] macvlan: fix failure during registration v3

From: Francesco Ruggeri <fruggeri@...sta.com>
Date: Sat, 23 Apr 2016 15:03:32 -0700

> If macvlan_common_newlink fails in register_netdevice after macvlan_init
> then it decrements port->count twice, first in macvlan_uninit (from
> register_netdevice or rollback_registered) and then again in
> macvlan_common_newlink.
> A similar problem may exist in the ipvlan driver.
> This patch consolidates modifications to port->count into macvlan_init
> and macvlan_uninit (thanks to Eric Biederman for suggesting this approach).
> 
> v3: remove macvtap specific bits.
> 
> Signed-off-by: Francesco Ruggeri <fruggeri@...sta.com>

Applied.