netdev - Re: [PATCH net-next] macvtap: check minor when unregistering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160426.151919.1718268588062036257.davem@davemloft.net>
Date:	Tue, 26 Apr 2016 15:19:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	fruggeri@...sta.com
Cc:	netdev@...r.kernel.org, ebiederm@...ssion.com
Subject: Re: [PATCH net-next] macvtap: check minor when unregistering

From: Francesco Ruggeri <fruggeri@...sta.com>
Date: Sat, 23 Apr 2016 15:04:31 -0700

> macvtap_device_event(NETDEV_UNREGISTER) should check vlan->minor to
> determine if it is being invoked in the context of a macvtap_newlink
> that failed, for example in this code sequence:
> 
> macvtap_newlink
>   macvlan_common_newlink
>     register_netdevice
>       call_netdevice_notifiers(NETDEV_REGISTER, dev)
>         macvtap_device_event(NETDEV_REGISTER)
>           <fail here, vlan->minor = 0>
>       rollback_registered(dev);
>         rollback_registered_many
>           call_netdevice_notifiers(NETDEV_UNREGISTER, dev);
>             macvtap_device_event(NETDEV_UNREGISTER)
>               <nothing to clean up here>
> 
> Signed-off-by: Francesco Ruggeri <fruggeri@...sta.com>

Applied.