netdev - Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160427155446.GD1962@nanopsycho.orion>
Date:	Wed, 27 Apr 2016 17:54:46 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:	Florian Westphal <fw@...len.de>, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] drivers/net: add 6WIND SHULTI support

Wed, Apr 27, 2016 at 05:38:09PM CEST, nicolas.dichtel@...nd.com wrote:
>Le 27/04/2016 17:14, Jiri Pirko a écrit :
>> Wed, Apr 27, 2016 at 11:56:15AM CEST, fw@...len.de wrote:
>>> Nicolas Dichtel <nicolas.dichtel@...nd.com> wrote:
>>>> This patch adds the support of the 6WIND SHULTI switch. It is a software
>>>> switch doing L2 forwarding.
>>>>
>>>> This first version implements the minimum needed to get the device working.
>>>> It also implements, via switchdev and rtnetlink, bridge forwarding offload,
>>>> including FDB static entries, FDB learning and FDB ageing.
>>>
>>> How is this different from net/bridge?
>>> How is this different from openvswitch?
>> 
>> The difference is that it this tries to allow userspace crap to mirror
>> setting user does for bridge/ovs. Basically this looks to me like an
>> attempt to enable userspace SDKs and such.
>> 
>It is software switch, allowed by the switchdev model (see
>Documentation/networking/switchdev.txt), same design as mellanox spectrum.

Switchdev purpose is to offload stuff down to HW.
You say your switch is software, so integrate it properly into kernel.
Easy.


>
>What's wrong with that?

What's wrong is that your driver allows many userspace proprietary SDKs
to work on out-of-box kernel. This is called "trampoline model". You
basically enable userspace drivers for switches and stuff like that.
This was discussed many many times.