netdev - Re: [PATCH v4 net-next 2/2] ppp: add rtnetlink device creation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160429.161011.1162718802493722811.davem@davemloft.net>
Date:	Fri, 29 Apr 2016 16:10:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	g.nault@...halink.fr
Cc:	netdev@...r.kernel.org, linux-ppp@...r.kernel.org,
	paulus@...ba.org, stephen@...workplumber.org, wharms@....de
Subject: Re: [PATCH v4 net-next 2/2] ppp: add rtnetlink device creation
 support

From: Guillaume Nault <g.nault@...halink.fr>
Date: Thu, 28 Apr 2016 17:55:30 +0200

> Define PPP device handler for use with rtnetlink.
> The only PPP specific attribute is IFLA_PPP_DEV_FD. It is mandatory and
> contains the file descriptor of the associated /dev/ppp instance (the
> file descriptor which would have been used for ioctl(PPPIOCNEWUNIT) in
> the ioctl-based API). The PPP device is removed when this file
> descriptor is released (same behaviour as with ioctl based PPP
> devices).
> 
> PPP devices created with the rtnetlink API behave like the ones created
> with ioctl(PPPIOCNEWUNIT). In particular existing ioctls work the same
> way, no matter how the PPP device was created.
> The rtnl callbacks are also assigned to ioctl based PPP devices. This
> way, rtnl messages have the same effect on any PPP devices.
> The immediate effect is that all PPP devices, even ioctl-based
> ones, can now be removed with "ip link del".
> 
> A minor difference still exists between ioctl and rtnl based PPP
> interfaces: in the device name, the number following the "ppp" prefix
> corresponds to the PPP unit number for ioctl based devices, while it is
> just an unrelated incrementing index for rtnl ones.
> 
> Signed-off-by: Guillaume Nault <g.nault@...halink.fr>

Series applied, thanks for doing this work!