netdev - Re: [PATCH] pxa168_eth: fix mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 1 May 2016 23:30:06 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:	arnd@...db.de
Subject: Re: [PATCH] pxa168_eth: fix mdiobus_scan() error check

On 05/01/2016 11:25 PM, Sergei Shtylyov wrote:

>>> Since mdiobus_scan() returns either an error code or NULL on error, the
>>> driver should check  for both,  not only for NULL, otherwise a crash is
>>> imminent...
>>>
>>> Reported-by: Arnd Bergmann <arnd@...db.de>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>>>
>>> ---
>>> The patch is against DaveM's 'net.git' repo.
>>>
>>>   drivers/net/ethernet/marvell/pxa168_eth.c |    2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> Index: net/drivers/net/ethernet/marvell/pxa168_eth.c
>>> ===================================================================
>>> --- net.orig/drivers/net/ethernet/marvell/pxa168_eth.c
>>> +++ net/drivers/net/ethernet/marvell/pxa168_eth.c
>>> @@ -979,6 +979,8 @@ static int pxa168_init_phy(struct net_de
>>>           return 0;
>>>
>>>       pep->phy = mdiobus_scan(pep->smi_bus, pep->phy_addr);
>>> +    if (IS_ERR(pep->phy))
>>> +        return PTR_ERR(pep->phy);
>>>       if (!pep->phy)
>>>           return -ENODEV;
>>
>> Should not this check be removed too and
>
>     That's my next move -- for now I'm fixing the existing bug in this driver
> only.

    In fact, it can't be removed yet as mdiobus_scan() may return NULL on 
other error path. There's certainly a space for improvements yet...
[...]

MBR, Sergei