netdev - Re: [PATCH v3 net] soreuseport: Fix TCP listener hash collision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160501.193805.651325884144750958.davem@davemloft.net>
Date:	Sun, 01 May 2016 19:38:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	kraigatgoog@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3 net] soreuseport: Fix TCP listener hash collision

From: Craig Gallek <kraigatgoog@...il.com>
Date: Thu, 28 Apr 2016 19:24:32 -0400

> From: Craig Gallek <kraig@...gle.com>
> 
> I forgot to include a check for listener port equality when deciding
> if two sockets should belong to the same reuseport group.  This was
> not caught previously because it's only necessary when two listening
> sockets for the same user happen to hash to the same listener bucket.
> The same error does not exist in the UDP path.
> 
> Fixes: c125e80b8868("soreuseport: fast reuseport TCP socket selection")
> Signed-off-by: Craig Gallek <kraig@...gle.com>

Applied.