netdev - Re: [PATCH net-next] ila: ipv6/ila: fix nlsize calculation for lwtunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160501.193926.994161705403597197.davem@davemloft.net>
Date:	Sun, 01 May 2016 19:39:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tom@...bertland.com
Cc:	netdev@...r.kernel.org, kernel-team@...com,
	nicolas.dichtel@...nd.com
Subject: Re: [PATCH net-next] ila: ipv6/ila: fix nlsize calculation for
 lwtunnel

From: Tom Herbert <tom@...bertland.com>
Date: Thu, 28 Apr 2016 17:12:29 -0700

> @@ -144,8 +144,12 @@ nla_put_failure:
>  
>  static int ila_encap_nlsize(struct lwtunnel_state *lwtstate)
>  {
> -	/* No encapsulation overhead */
> -	return 0;
> +	return
> +		/* ILA_ATTR_LOCATOR */
> +		nla_total_size(sizeof(u64)) +

As Nicolas stated, you need to use the 64-bit sizing helper here.