netdev - Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 3 May 2016 10:40:44 +0800
From:	Wang Shanker <shankerwangmiao@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	James Chapman <jchapman@...alix.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] ip: add udp_csum, udp6_csum_tx, udp6_csum_rx control flags to ip l2tp add tunnel

Thanks a lot.

I feel it excited to contribute to the development of kernel. I’ll do 
better next time.

> 在 2016年5月3日，06:19，Stephen Hemminger <stephen@...workplumber.org> 写道：
> 
> On Thu, 28 Apr 2016 15:50:47 +0100
> James Chapman <jchapman@...alix.com> wrote:
> 
>> Yes, that looks like the problem.
>> 
>> The comments in l2tp.h which indicate that the csum attributes are u8
>> values are wrong. Code in net/l2tp/l2tp_netlink.c accesses these
>> attributes using nla_get_flag().
>> 
>> Please submit a patch to fix l2tp_tunnel_sock_create(). Include good
>> change notes and your signed-off-by tag so that it gets reviewed. See
>> Documentation/SubmittingPatches if you haven't submitted a kernel
>> patch here before.
> 
> Thank you for fixing this. James is is correct.
> Please format the patch according to the submission guidelines.
> For example, checkpatch complains about current patch.
> 
> ERROR: code indent should use tabs where possible
> #156: FILE: net/l2tp/l2tp_core.c:1379:
> +                         ! cfg->udp6_zero_tx_checksums;$
> 
> WARNING: please, no spaces at the start of a line
> #156: FILE: net/l2tp/l2tp_core.c:1379:
> +                         ! cfg->udp6_zero_tx_checksums;$
> 
> ERROR: space prohibited after that '!' (ctx:ExW)
> #156: FILE: net/l2tp/l2tp_core.c:1379:
> +                         ! cfg->udp6_zero_tx_checksums;
>                          ^
> 
> ERROR: code indent should use tabs where possible
> #159: FILE: net/l2tp/l2tp_core.c:1381:
> +                         ! cfg->udp6_zero_rx_checksums;$
> 
> WARNING: please, no spaces at the start of a line
> #159: FILE: net/l2tp/l2tp_core.c:1381:
> +                         ! cfg->udp6_zero_rx_checksums;$
> 
> ERROR: space prohibited after that '!' (ctx:ExW)
> #159: FILE: net/l2tp/l2tp_core.c:1381:
> +                         ! cfg->udp6_zero_rx_checksums;
>                          ^
> 
> ERROR: Missing Signed-off-by: line(s)
> 
> 
> I am sorry that maintainers may seem like picky teachers in school
> always putting redline around spelling errors, but this is how we work to teach
> others how to follow the process.
> 


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4130 bytes)