netdev - Re: [PATCH net-next] ipv6: add new struct ipcm6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160502.224605.2041030786381936894.davem@davemloft.net>
Date:	Mon, 02 May 2016 22:46:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	weiwan@...gle.com
Cc:	netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net-next] ipv6: add new struct ipcm6_cookie

From: David Miller <davem@...emloft.net>
Date: Mon, 02 May 2016 22:39:45 -0400 (EDT)

> From: Wei Wang <weiwan@...gle.com>
> Date: Fri, 29 Apr 2016 17:31:12 -0700
> 
>> From: Wei Wang <weiwan@...gle.com>
>> 
>> In the sendmsg function of UDP, raw, ICMP and l2tp sockets, we use local
>> variables like hlimits, tclass, opt and dontfrag and pass them to corresponding
>> functions like ip6_make_skb, ip6_append_data and xxx_push_pending_frames.
>> This is not a good practice and makes it hard to add new parameters.
>> This fix introduces a new struct ipcm6_cookie similar to ipcm_cookie in
>> ipv4 and include the above mentioned variables. And we only pass the
>> pointer to this structure to corresponding functions. This makes it easier
>> to add new parameters in the future and makes the function cleaner.
>> 
>> Signed-off-by: Wei Wang <weiwan@...gle.com>
> 
> Looks good, applied, thank you.

Actually I had to revert, this break the build.

net/l2tp/l2tp_ip6.c: In function ‘l2tp_ip6_sendmsg’:
net/l2tp/l2tp_ip6.c:634:10: error: invalid operands to binary & (have ‘struct ipcm6_cookie *’ and ‘struct flowi6’)
          &fl6, (struct rt6_info *)dst,
          ^
net/l2tp/l2tp_ip6.c:634:16: warning: passing argument 7 of ‘ip6_append_data’ from incompatible pointer type
          &fl6, (struct rt6_info *)dst,
                ^

and so on and so forth...