netdev - Re: [PATCH net] bridge: fix igmp / mld query parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160503132623.59cf54fb@xeon-e3>
Date:	Tue, 3 May 2016 13:26:23 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Linus Lüssing <linus.luessing@...3.blue>
Cc:	netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
	bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	Simon Wunderlich <sw@...onwunderlich.de>
Subject: Re: [PATCH net] bridge: fix igmp / mld query parsing

On Tue,  3 May 2016 22:18:54 +0200
Linus Lüssing <linus.luessing@...3.blue> wrote:

> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 03661d9..7105cdf 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1271,6 +1271,7 @@ static int br_ip4_multicast_query(struct net_bridge *br,
>  	unsigned long max_delay;
>  	unsigned long now = jiffies;
>  	__be32 group;
> +	int offset = skb_transport_offset(skb);
shouldn't this be unsigned?