lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 May 2016 16:59:11 +0200 From: Linus Lüssing <linus.luessing@...3.blue> To: Stephen Hemminger <stephen@...workplumber.org> Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, Simon Wunderlich <sw@...onwunderlich.de> Subject: Re: [PATCH net] bridge: fix igmp / mld query parsing On Tue, May 03, 2016 at 01:26:23PM -0700, Stephen Hemminger wrote: > On Tue, 3 May 2016 22:18:54 +0200 > Linus Lüssing <linus.luessing@...3.blue> wrote: > > > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c > > index 03661d9..7105cdf 100644 > > --- a/net/bridge/br_multicast.c > > +++ b/net/bridge/br_multicast.c > > @@ -1271,6 +1271,7 @@ static int br_ip4_multicast_query(struct net_bridge *br, > > unsigned long max_delay; > > unsigned long now = jiffies; > > __be32 group; > > + int offset = skb_transport_offset(skb); > shouldn't this be unsigned? Yes, should always be unsigned here. Ok, I'm changing that (even though skb_transport_offset() is "static inline int").
Powered by blists - more mailing lists