netdev - Re: [PATCH net] net/mlx4_en: Fix endianness bug in IPV6 csum calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160505.232706.406069830279349152.davem@davemloft.net>
Date:	Thu, 05 May 2016 23:27:06 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tariqt@...lanox.com
Cc:	netdev@...r.kernel.org, danielj@...lanox.com
Subject: Re: [PATCH net] net/mlx4_en: Fix endianness bug in IPV6 csum
 calculation

From: Tariq Toukan <tariqt@...lanox.com>
Date: Wed,  4 May 2016 15:00:33 +0300

> From: Daniel Jurgens <danielj@...lanox.com>
> 
> Use htons instead of unconditionally byte swapping nexthdr.  On a little
> endian systems shifting the byte is correct behavior, but it results in
> incorrect csums on big endian architectures.
> 
> Fixes: f8c6455bb04b ('net/mlx4_en: Extend checksum offloading by CHECKSUM COMPLETE')
> Signed-off-by: Daniel Jurgens <danielj@...lanox.com>
> Reviewed-by: Carol Soto <clsoto@...ibm.com>
> Tested-by: Carol Soto <clsoto@...ibm.com>
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>

Applied and queued up for -stable, thanks.