netdev - Re: [PATCH] VSOCK: do not disconnect socket when peer has shutdown SEND only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160505.233208.1854080809719423732.davem@davemloft.net>
Date:	Thu, 05 May 2016 23:32:08 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ian.campbell@...ker.com
Cc:	netdev@...r.kernel.org, stefanha@...hat.com,
	imbrenda@...ux.vnet.ibm.com, acking@...are.com, dtor@...are.com,
	jhansen@...are.com, aditr@...are.com
Subject: Re: [PATCH] VSOCK: do not disconnect socket when peer has shutdown
 SEND only

From: Ian Campbell <ian.campbell@...ker.com>
Date: Wed,  4 May 2016 14:21:53 +0100

> The peer may be expecting a reply having sent a request and then done a
> shutdown(SHUT_WR), so tearing down the whole socket at this point seems
> wrong and breaks for me with a client which does a SHUT_WR.
> 
> Looking at other socket family's stream_recvmsg callbacks doing a shutdown
> here does not seem to be the norm and removing it does not seem to have
> had any adverse effects that I can see.
> 
> I'm using Stefan's RFC virtio transport patches, I'm unsure of the impact
> on the vmci transport.
> 
> Signed-off-by: Ian Campbell <ian.campbell@...ker.com>

Applied and queued up for -stable, thanks.