netdev - Re: [PATCH net] net: bridge: fix old ioctl unlocked net device walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160505.233322.2284182158683953456.davem@davemloft.net>
Date:	Thu, 05 May 2016 23:33:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nikolay@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	stephen@...workplumber.org
Subject: Re: [PATCH net] net: bridge: fix old ioctl unlocked net device walk

From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Date: Wed,  4 May 2016 16:18:45 +0200

> get_bridge_ifindices() is used from the old "deviceless" bridge ioctl
> calls which aren't called with rtnl held. The comment above says that it is
> called with rtnl but that is not really the case.
> Here's a sample output from a test ASSERT_RTNL() which I put in
> get_bridge_ifindices and executed "brctl show":
 ...
> Since it only reads bridge ifindices, we can use rcu to safely walk the net
> device list. Also remove the wrong rtnl comment above.
> 
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
> AFAICT this has been present since the beginning of git history thus no
> fixes tag.

Applied and queued up for -stable, thanks.