lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1462815597.23934.35.camel@edumazet-glaptop3.roam.corp.google.com> Date: Mon, 09 May 2016 10:39:57 -0700 From: Eric Dumazet <eric.dumazet@...il.com> To: Alexander Duyck <alexander.duyck@...il.com> Cc: David Miller <davem@...emloft.net>, Vlad Yasevich <vyasevic@...hat.com>, Alexander Duyck <aduyck@...antis.com>, netdev <netdev@...r.kernel.org>, Tom Herbert <tom@...bertland.com> Subject: Re: [PATCH v2 net-next] ifb: support more features On Mon, 2016-05-09 at 10:22 -0700, Alexander Duyck wrote: > One thought that just occurred to me based on this would be to > configure inner headers on the way up, and to configure the outer > headers on the way down. Then that way we could go through and be > guaranteed that the inner headers represent the inner most set of > header offsets, and the outer ones represent the outer-most set > regardless of the total number of headers present and there would be > no need to call into the reset_headers function since all the headers > would already be set. > > I was also looking at possibly dropping the inner transport offset as > from what I can tell it and the csum_offset should always be the same > value since csum_offset will always point to the inner transport > header when any kind of offload is enabled which is the criteria for > skb->encapsulation being set anyway. Ideally nothing should be changed in the source skb while doing gso_segment() calls. As we did in gro_complete() when adding nhoff argument, we probably could pass the current offset and not touch skb->data and various header offsets. Presumably gso state should be stored in a separate structure. I meant, gso_segment() is not a 'please sanity fix this skb'. Only DODGY thing might need to ?
Powered by blists - more mailing lists